Added Imagick to the php runtimes #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added php8.2-imagick into the docker file as this is a very common package used by multiple services
driesvints
approved these changes
Mar 1, 2023
|
Are you sure this is all that is needed. For example on Forge we also run: apt-get install -y --force-yes libmagickwand-dev |
|
yes you do not need that. Please see reference https://packages.debian.org/buster/libmagickwand-dev The main thing to know is Imagick will install whatever dependencies it needs during install but for a functional system without turning Sail into a massive one-off solution, all that is needed is imagick. I have tested this on all php versions with Intervention, Spatie Media Library, Spatie Image and direct imagick manipulation just to make sure there were no standards deps missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am suggesting adding phpx.x-imagick to the dockerfile for each runtime. The reason this would help others is Imagick is quite common in its use when it comes to using Intervention, Spatie packages as well as general image manipulation. This would save a lot of time and stress for people having to customize their dockerfile. By preventing one-off customizations a lot of issues will be alleviated from various issue reports.
I did test this on each runtime and there are no errors or deployment issues.