Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metabase's additional parameters #1

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Add Metabase's additional parameters #1

merged 2 commits into from
Dec 22, 2021

Conversation

SebastianSchoeps
Copy link
Contributor

This PR adds the possibility to use Metabase's additional parameters:

  • bordered
  • titled
  • theme

Currently those are hard-coded.

bordered currently defaults to true. I would prefer to default this to false so that you don't have to actually disable it in the blade component:

<x-metabase dashboard="1" :params="$params" :bordered="false"></x-metabase>

Enabling would be easy:

<x-metabase dashboard="1" :params="$params" bordered></x-metabase>

I have left it like before so that this PR is not breaking.

@uyab
Copy link
Contributor

uyab commented Dec 22, 2021

I agree with false as default value for "bordered" params. It is ok if we have breaking changes, still in early version :)

@SebastianSchoeps
Copy link
Contributor Author

I changed the default value - ready to merge! :-)

@uyab uyab merged commit 26637df into laravolt:main Dec 22, 2021
@uyab
Copy link
Contributor

uyab commented Dec 22, 2021

Thank your for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants