Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency "mime-types" #264

Closed
wants to merge 1 commit into from

Conversation

nj
Copy link

@nj nj commented Jun 25, 2017

mime-types is not referenced in the code, making it unused.

Was originally introduced through eventfuel#4.

Have cherry-picked from #251, which most likely was closed due to build failure. Without the lock that also was introduced in that PR, everything seems to go as expected - so Travis is happy 😉

@piya23300
Copy link

I have a problem.

Bundler could not find compatible versions for gem "mime-types":
  In snapshot (Gemfile.lock):
    mime-types (= 3.1)

  In Gemfile:
    carrierwave_backgrounder was resolved to 0.4.2, which depends on
      mime-types (~> 2.99)

    google-api-client (~> 0.11) was resolved to 0.19.8, which depends on
      mime-types (~> 3.0)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

I think this MR can fix it.

@nj nj mentioned this pull request Jul 1, 2018
@nj
Copy link
Author

nj commented Jul 1, 2018

@piya23300 Yeah, but sadly it seems like the gem isn't maintained any longer 😢 Been over a year since last change.

What you could do though, is reference my branch or pick one of the many other forks that have handled the issue, so you're not "blocked" from upgrading.

@piya23300
Copy link

piya23300 commented Jul 2, 2018

@nj this gem is live or not? it has many PRs but gem owner doesn't response.

I have problems

Can you suggest a good fork?

@lardawge
Copy link
Owner

lardawge commented Dec 9, 2020

Fixed in master

@lardawge lardawge closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants