Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology: Independent or dependent variable? #51

Closed
shleeneu opened this issue Oct 23, 2023 · 6 comments
Closed

Terminology: Independent or dependent variable? #51

shleeneu opened this issue Oct 23, 2023 · 6 comments
Assignees

Comments

@shleeneu
Copy link

In the lares package, I noticed what you mean by "independent" variable is the outcome variable. However, in most textbooks, the outcome variable is commonly referred to as the "response" or "dependent" variable, whereas the "independent" variable mostly refers to "predictors" or "features". See the textbook "An Introduction to Statistical Learning with Applications in R", page 16.

I'd suggest updating the terminology wherever it appears.

@laresbernardo
Copy link
Owner

Thanks for your feedback @shleeneu
Can you share a couple of examples of where this is happening in the code/documentation? We can fix whatever is wrong and consider improving the wording for parameters if needed.

@laresbernardo laresbernardo self-assigned this Oct 23, 2023
@laresbernardo laresbernardo added bug Something isn't working documenation and removed bug Something isn't working labels Oct 23, 2023
@shleeneu
Copy link
Author

Here are a few instances:

Please note there are a few other places. I want to make sure I am not misunderstanding your code.

@laresbernardo
Copy link
Owner

Ah yes, you're absolutely right @shleeneu Don't know why it took so long for someone (including me) to notice. Will fix it ASAP! Thanks for reporting it

@laresbernardo
Copy link
Owner

I've fixed the documentation. There was no need to change any parameter name so it was an easy fix. Feel free to close this issue if you agree

@shleeneu
Copy link
Author

Awesome, glad to have helped. Just one more:

1. Input a dataframe `df` and choose which one is the independent variable (`y`) you'd like to predict. You may set/change the `seed` argument to guarantee reproducibility of your results.

@laresbernardo
Copy link
Owner

Fixed, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants