Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParserInteractive.accepts #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thekevinscott
Copy link
Contributor

@thekevinscott thekevinscott commented Feb 19, 2024

@erezsh
Copy link
Member

erezsh commented Feb 19, 2024

(Yes, the failure is due to the Lark python version not being pinned. We'll try again later)

@thekevinscott
Copy link
Contributor Author

thekevinscott commented Feb 19, 2024

Though this fixes the specific bug I encountered, I may have introduced another bug.

Should t refer to the key of the choices dictionary, or the value?

It seems like it should be referencing the key, as far as I can tell from poking around my generated parser, but in this PR I have it referencing the dict's value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants