Remove filter_format attribute from IR and bconv kernel #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tombana
reviewed
May 28, 2020
| ConstantAttr<StrAttr, "OHWI">, $fused_activation_function, | ||
| $fused_activation_function, |
There was a problem hiding this comment.
Running the pattern only once is now ensured by the filter tensor type, instead of this argument, right?
There was a problem hiding this comment.
Yes, it is should now be handled by this check:
inside the
Conv2DFilter attr constraint
Tombana
approved these changes
May 28, 2020
lgeiger
force-pushed
the
remove-filter-format-attr
branch
from
c7e3b09
to
634b765
Compare
AdamHillier
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a follow up to #373 and removes the
filter_formatattribute from the IR and the bconv kernels since we only supportOHWIandOHWI_PACKEDwhich can be infered by the dtype inPrepareHow Has This Been Tested?
CI
Related issue number
This targets the branch of #373 but can be reviewed independently.