(Partially) add type hints. See #309. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamHillier
force-pushed
the
add-type-hints
branch
from
e3cb489
to
38c079f
Compare
AdamHillier
force-pushed
the
add-type-hints
branch
from
38c079f
to
e6cfe8a
Compare
AdamHillier
force-pushed
the
add-type-hints
branch
from
e6cfe8a
to
246a64a
Compare
lgeiger
requested changes
Jan 20, 2020
larq/constraints.py
Outdated
| return tf.clip_by_value(x, -self.clip_value, self.clip_value) | ||
|
|
||
| def get_config(self): | ||
| def get_config(self) -> Dict: |
There was a problem hiding this comment.
General Python typehints question: Is using the builtin dict equivalent to typings.Dict in this case?
Suggested change
| def get_config(self) -> Dict: | |
| def get_config(self) -> dict: |
There was a problem hiding this comment.
Not 100% sure about the difference, but now I look into it apparently it's better to use typing.Mapping for such things, so I will edit.
lgeiger
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.