Ternary #86
Merged
Ternary #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
requested changes
May 8, 2019
larq/quantizers.py
Outdated
| return _ternarize_with_identity_grad(x) | ||
|
|
||
| def threshold_twn(self, x): | ||
| x_sum = tf.reduce_sum(tf.abs(x)) |
There was a problem hiding this comment.
Do we need a tf.stop_gradient here?
There was a problem hiding this comment.
I am unsure, I briefly looked up the documentation and I don't think we do, but there is a significant chance that I am incorrect
lgeiger
reviewed
May 8, 2019
|
@lgeiger I have responded to all of your review comments, please look at the azure pipeline when you have time |
until we have full support for ternary in the summary
lgeiger
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ternarization. Currently still need to do unit tests before can be merged.