Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement one-padding and reduce number of SE blocks for QuickNet #136

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Implement one-padding and reduce number of SE blocks for QuickNet #136

merged 4 commits into from
Mar 20, 2020

Conversation

koenhelwegen
Copy link
Contributor

This PR introduces one-padding for QuickNet and QuickNet large, and reduces the number of squeeze & excite blocks on QuickNet Large. This leads to faster inference times at no cost in accuracy.

The new benchmark results are described in larq/compute-engine#294.

The new model files are released in:

lgeiger
lgeiger reviewed Mar 20, 2020
View reviewed changes
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments for improved readability

larq_zoo/sota/quicknet_large.py Outdated Show resolved Hide resolved
larq_zoo/sota/quicknet_large.py Outdated Show resolved Hide resolved
larq_zoo/sota/quicknet_large.py Outdated Show resolved Hide resolved
Koen Helwegen and others added 2 commits March 20, 2020 13:11
@lgeiger
Apply suggestions from code review
e4c4611 
Co-Authored-By: Lukas Geiger <lgeiger@users.noreply.github.com>
@lgeiger
⬆️ larq@0.9.2
5f448bd
lgeiger
lgeiger requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upload the json model architectures (model.to_json()) to the releases as well, so the netron graph is up to date.

This requires updating this line and this one

@lgeiger lgeiger added the feature New feature or request label Mar 20, 2020
@lgeiger lgeiger merged commit d3e96b1 into master Mar 20, 2020
@lgeiger lgeiger deleted the quicknet-one-padding branch March 20, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koenhelwegen @lgeiger