If the failure message or stack contains colors, the XML will render invalid #170
Conversation
src/junit_reporter.js
Outdated
| function escapeInvalidXmlChars(str) { | ||
| return str.replace(/\&/g, "&") | ||
| const escaped = str.replace(/\&/g, "&") |
There was a problem hiding this comment.
This must not use const in any of the reporter source files, as it may be used on a browser version that does not support const—this should be var for maximum compatibility. New keywords are fine to use in the spec files (as they only run in node), but reporter files need to be much more backwards compatible.
I am happy to merge this PR if it is updated to use var.
Thanks.
There was a problem hiding this comment.
This must not use const in any of the reporter source files, as it may be used on a browser version that does not support const—this should be var for maximum compatibility. New keywords are fine to use in the spec files (as they only run in node), but reporter files need to be much more backwards compatible.
I am happy to merge this PR if it is updated to use var.
(Sorry for the double entry, this is my first time using the "Review changes" feature.)
|
@bloveridge Changed |
|
Thanks! |
The attached file was produced with the JUnitXmlReporter: test-results.xml.zip
It is invalid XML as a
<![CDATA[blob contains the 0x1B byte on line 1045 at column 71, which is not proper UTF-8.This PR introduces
escapeControlCharswhich is a less agressive escape function that is now used byescapeInvalidXmlCharsafter escaping <, />, etc.escapeControlCharsnow wraps the failure.stack || failure.message to get rid of the unwanted bytes.