Delete news item #213
Merged
Delete news item #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, definitely need this feature. Would you mind a quick rebase? There's a conflict I'm not sure about. |
(Refs Issue larvalabs#100) * User can delete their own news item and all child comments * Make delete button a mixin * Add confirmation modal to both news item and comment delete
|
@megamattron Rebased and resolved. |
|
It seems kind of strange to delete other users' comments on a news item when the news item is deleted, but it also seems strange to keep them. Any thoughts on potential issues with this? |
|
Thought about this, but I kind of like a scorched earth policy. If someone wants to change this in a later pull request they're obviously certainly welcome to. 😸 |
|
Haha fair enough. I guess if it becomes a problem we can change it. |
|
Ok thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Refs Issue #100)