Improve "Last Comment" Feature #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, can you rebase and I'll put it in. |
…s unvisited links
|
Rebased and all set to go. Also fixes the double render on the issues page. |
megamattron
added a commit
that referenced
this pull request
Feb 20, 2014
Improve "Last Comment" Feature
|
Thanks, releasing now. |
Closed
|
@treygriffith Thanks for cleaning up after me - I was feeling like quite the dunce letting that slip through. |
|
@josephwegner no problem, I actually thought I had messed something up during my rebase from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of queries needed to build the home page by performing the score-based sort prior to fetching comment count and last comment time. It's a big difference, from 1803 queries to 63.
It also adds a query string to the comments link, which allows the browser to show the link as unvisited if there are new comments, addressing #200 (credit to http://www.joelonsoftware.com/articles/BuildingCommunitieswithSo.html).
Lastly, it adds the same functionality to the Issues page, and fixes a minor bug where the issue title was linking to the API instead of the regular Github site (#242).