Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic font size scaling for title label #4

Merged
merged 15 commits into from
Jun 21, 2022
Merged

Enable dynamic font size scaling for title label #4

merged 15 commits into from
Jun 21, 2022

Conversation

FelixLisczyk
Copy link
Contributor

@FelixLisczyk FelixLisczyk commented Jun 3, 2022

WIP for #3

@lascic lascic added the bug Something isn't working label Jun 19, 2022
@lascic lascic linked an issue Jun 19, 2022 that may be closed by this pull request
@lascic lascic marked this pull request as ready for review June 19, 2022 15:51
@lascic
Copy link
Owner

lascic commented Jun 19, 2022

I managed to implement the logic for adjusting the font size if either the welcome text or app name text gets smaller so that the smaller font size gets applied for both title labels in the stack. The line height looks still alright to me, no need to change something there.
If everything looks good to you, I'll add those changes to the package project before we merge it to main and close this issue.

Rename welcomeTitle and appTitle input parameters as well as related properties to first- and secondTitleLine(-Label).
In other localizations, the app name may be set on the first line followed by the welcome text on the second (and/or partially on first) line and vice versa.
This issue happened after transitioning from one welcome title label to a welcome title label stack.

The parent onboarding stack height changes between view controller lifecycle and environment changes, which made the controller show the bottom blur even though there was enough space to show the full feature list.
We call updateUI again after the initial onboarding animation has completed, reading the actual onboarding stack height and therefore correctly showing or hiding the bottom blur view.
Copy link
Contributor Author

@FelixLisczyk FelixLisczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 👍

@lascic lascic merged commit b1ca7b0 into lascic:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dynamic font size scaling in title label
2 participants