Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt 2.4.1 #224

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Scalafmt 2.4.1 #224

merged 2 commits into from
Feb 20, 2020

Conversation

barambani
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 15, 2020

Codecov Report

Merging #224 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   62.23%   62.14%   -0.09%     
==========================================
  Files          38       38              
  Lines        1287     1284       -3     
  Branches        8        6       -2     
==========================================
- Hits          801      798       -3     
  Misses        486      486
Impacted Files Coverage Δ
fs2/src/main/scala/laserdisc/fs2/RedisClient.scala 64.28% <100%> (-1.24%) ⬇️
...main/scala/laserdisc/protocol/RESPParamWrite.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9f39d...f7a67d1. Read the comment docs.

@barambani
Copy link
Member Author

barambani commented Feb 15, 2020

Actually I don't think this new formatting is better than the previous one. I would close this.

UPDATE: being up to date with the releases has its benefits so I guess we have to bring it in. We might tune the config if it's really unpleasant, what do you think ?

@barambani barambani changed the title Scalafmt 2.4.0 Scalafmt 2.4.1 Feb 16, 2020
@sirocchj
Copy link
Member

Let’s get it in. I don’t mind the formatting but if you want to customise please do

@barambani barambani merged commit ed3e61f into laserdisc-io:master Feb 20, 2020
@barambani barambani deleted the scala-format branch February 20, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants