New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency from typelevel compiler #49

Merged
merged 6 commits into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@barambani
Member

barambani commented Oct 26, 2018

No description provided.

@barambani barambani requested a review from sirocchj Oct 26, 2018

barambani added some commits Oct 26, 2018

@sirocchj

change looks great to me, just minor style difference in build.sbt, feel free to discard. Can you also modify the README.md accordingly though? There's a section that talks about literal types which needs to go. The one about induction heuristics probably we can leave, scoping it to 2.11 though, wdyt?

build.sbt Outdated
@@ -18,6 +23,7 @@ val `fs2-core` = Def.setting("co.fs2" %%% "fs2-core" % V.
val `fs2-io` = Def.setting("co.fs2" %% "fs2-io" % V.fs2)
val kittens = Def.setting("org.typelevel" %%% "kittens" % V.kittens)
val refined = Def.setting("eu.timepit" %%% "refined" % V.refined)
val refined211 = Def.setting("eu.timepit" %%% "refined" % V.refined211)

This comment has been minimized.

@sirocchj

sirocchj Oct 29, 2018

Member

suggestion: remove line above and change this to

Suggested change Beta
val refined211 = Def.setting("eu.timepit" %%% "refined" % V.refined211)
val refined = Def.setting {
CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, 11)) => "eu.timepit" %%% "refined" % V.refined211
case _ => "eu.timepit" %%% "refined" % V.refined
}
}

then you could revert all relevant changes around this below

This comment has been minimized.

@barambani

barambani Oct 29, 2018

Member

nice. I'll do it

@barambani barambani merged commit 542adab into laserdisc-io:master Oct 29, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@barambani barambani deleted the barambani:compiler branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment