Removed dependency from typelevel compiler #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirocchj
previously approved these changes
Oct 29, 2018
There was a problem hiding this comment.
change looks great to me, just minor style difference in build.sbt, feel free to discard. Can you also modify the README.md accordingly though? There's a section that talks about literal types which needs to go. The one about induction heuristics probably we can leave, scoping it to 2.11 though, wdyt?
sirocchj
reviewed
Oct 29, 2018
build.sbt
Outdated
| @@ -18,6 +23,7 @@ val `fs2-core` = Def.setting("co.fs2" %%% "fs2-core" % V. | |||
| val `fs2-io` = Def.setting("co.fs2" %% "fs2-io" % V.fs2) | |||
| val kittens = Def.setting("org.typelevel" %%% "kittens" % V.kittens) | |||
| val refined = Def.setting("eu.timepit" %%% "refined" % V.refined) | |||
| val refined211 = Def.setting("eu.timepit" %%% "refined" % V.refined211) | |||
There was a problem hiding this comment.
suggestion: remove line above and change this to
Suggested change
| val refined211 = Def.setting("eu.timepit" %%% "refined" % V.refined211) | |
| val refined = Def.setting { | |
| CrossVersion.partialVersion(scalaVersion.value) match { | |
| case Some((2, 11)) => "eu.timepit" %%% "refined" % V.refined211 | |
| case _ => "eu.timepit" %%% "refined" % V.refined | |
| } | |
| } |
then you could revert all relevant changes around this below
sirocchj
approved these changes
Oct 29, 2018
sirocchj
pushed a commit
that referenced
this pull request
Nov 21, 2018
Missed from 9fed6a3#diff-fdd474a48c4fe3ebdf7d61e23dc2aa53R27 in pull request #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.