Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of <: Singleton and usages #63

Merged
merged 1 commit into from Dec 4, 2018

Conversation

sirocchj
Copy link
Member

@sirocchj sirocchj commented Dec 3, 2018

mset and hmset were broken due to the presence of type XString = String <: Singleton and its attempted usage via type SingletonKey[A <: XString] = A Refined NonEmpty

mset and hmset were broken due to the presence of XString = String <: Singleton and its attempted usage via SingletonKey[A <: XString] = A Refined NonEmpty
@codecov-io
Copy link

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   22.84%   22.84%           
=======================================
  Files          33       33           
  Lines         950      950           
  Branches       18       16    -2     
=======================================
  Hits          217      217           
  Misses        733      733
Impacted Files Coverage Δ
core/src/main/scala/laserdisc/package.scala 52.17% <ø> (ø) ⬆️
core/src/main/scala/laserdisc/protocol/HashP.scala 0% <ø> (ø) ⬆️
...re/src/main/scala/laserdisc/protocol/StringP.scala 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5f9d9...e22a1c6. Read the comment docs.

Copy link
Member

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add some tests later.

@sirocchj sirocchj merged commit 5ed89f3 into laserdisc-io:master Dec 4, 2018
@sirocchj sirocchj deleted the complete-removal-sip23 branch December 4, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants