Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cargo fmt instead of rustfmt #88

Merged
merged 1 commit into from
May 13, 2020
Merged

Use cargo fmt instead of rustfmt #88

merged 1 commit into from
May 13, 2020

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented May 13, 2020

This fixes #87

sondr3
sondr3 commented May 13, 2020
View reviewed changes
format-all.el Show resolved Hide resolved
@lassik lassik merged commit 0227e1a into lassik:master May 13, 2020
@lassik
Copy link
Owner

lassik commented May 13, 2020

LGTM. Thank you for taking the time to send a PR!

@sondr3 sondr3 deleted the cargo-fmt branch May 13, 2020 19:35
@jenanwise jenanwise mentioned this pull request Aug 2, 2020
Closed
lassik added a commit that referenced this pull request Aug 4, 2020
@lassik
Switch back from cargo fmt to plain rustfmt (#95)
ccfff41 
"cargo fmt" currently doesn't work sensibly for stdin->stdout
formatting -- if the project has multiple Rust source files, it
formats all of them instead of formatting only the one we want. There
is currently no way to fix this in "cargo fmt", so revert to
"rustfmt".

Thanks to Sondre Nilsen for solving this problem.

See also issue #88 (Use cargo fmt instead of rustfmt).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassik lassik lassik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cargo fmt, not rustfmt
2 participants
@sondr3 @lassik