-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "pins: remove GlobalSign R1/R3 pins" #410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 46e2a0f.
Fixes #409 |
Just to make it clear: Adding R1 is not necessary. I have no idea if it might be useful in the future, but it's not required if you plan on making a more elaborate fix later. |
I have tested this locally with the latest mater commit and it works like a charm. |
Thank you for the quick fix! |
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
May 18, 2018
Use an overlay to pick up a critical bug-fix from the lastest version. Without this, lpass is unusable due to a certificate change that took place. lastpass/lastpass-cli#409 lastpass/lastpass-cli#410
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
May 19, 2018
Use an overlay to pick up a critical bug-fix from the lastest version. Without this, lpass is unusable due to a certificate change that took place. lastpass/lastpass-cli#409 lastpass/lastpass-cli#410
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
May 27, 2018
Use an overlay to pick up a critical bug-fix from the lastest version. Without this, lpass is unusable due to a certificate change that took place. lastpass/lastpass-cli#409 lastpass/lastpass-cli#410
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
May 27, 2018
Use an overlay to pick up a critical bug-fix from the lastest version. Without this, lpass is unusable due to a certificate change that took place. lastpass/lastpass-cli#409 lastpass/lastpass-cli#410
ivanbrennan
added a commit
to ivanbrennan/nixbox
that referenced
this pull request
May 27, 2018
Use an overlay to pick up a critical bug-fix from the lastest version. Without this, lpass is unusable due to a certificate change that took place. lastpass/lastpass-cli#409 lastpass/lastpass-cli#410
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 46e2a0f.
LP just got a new R3 cert and it broke the world; add back in R1/R3 so that lastpass-cli will start working again. Hopefully the certificate issue can also be resolved on the server so that all existing clients aren't bricked.