Correct product-listing/category-row display for 'columns' display

[proseLA]

i'm not really sure how people use this template out of the box. maybe i am missing something.

i think i am using this with all of the default settings.

my layout style based on that is now columns.

based on that, i now have a percentage for column width as dictated by this code:

ZCA-Bootstrap-Template/includes/modules/bootstrap/product_listing.php

Lines 122 to 130 in 369f288

	// if in fixed-columns mode, calculate column width
	if ($product_listing_layout_style === 'columns') {
	$calc_value = $columns_per_row;
	if ($num_products_count < $columns_per_row || $columns_per_row == 0) {
	$calc_value = $num_products_count;
	}
	$col_width = floor(100 / $calc_value) - 0.5;
	}

given the fact that there are only 3 products in this category, i now have a column width of 32.5; which looks to be a percentage as dictated here:

ZCA-Bootstrap-Template/includes/modules/bootstrap/product_listing.php

Lines 392 to 394 in 369f288

	if ($product_listing_layout_style === 'columns') {
	$style = ' style="width:' . $col_width . '%;"';
	}

and now, we use that with in-line styling (noooooo!!!!!!) here:

ZCA-Bootstrap-Template/includes/modules/bootstrap/product_listing.php

Lines 395 to 396 in 369f288

	$list_box_contents[$rows][] = [
	'params' => 'class="card mb-3 p-3 centerBoxContentsListing text-center h-100 "' . $style,

and then it finally gets output here:

ZCA-Bootstrap-Template/includes/templates/bootstrap/common/tpl_columnar_display.php

Lines 30 to 43 in 369f288

	<div class="card mb-3<?= $card_main_class ?>"<?= $card_main_id ?>>
	<?php
	echo $title;
	?>
	<div class="card-body text-center"<?= $card_body_id ?>>
	<?php
	if (is_array($list_box_contents)) {
	foreach ($list_box_contents as $row => $cols) {
	$r_params = $list_box_contents[$row]['params'] ?? 'class="card-deck text-center"';
	?>
	<div <?= $r_params ?>>
	<?php
	foreach ($cols as $col) {
	if ($cols === 'params') {

which is already a div within a div within a div. which is fine. except the product display is now 32.5% of the column as opposed to 32.5% of the viewporrt.

see:

what might i be missing?

removing the $style on line 396 above seems to resolve the issue. see:

again, what might i be missing here?

[lat9]

This configuration setting's directions:

Combined with this Wiki article.

[proseLA]

this does not explain the problem that i have presented.

you are explicitly stating that you do not recommend using a number other than 0 or 1. but if one chooses to use a non recommended number, the calculation is completely wrong. is that why it is not recommended?

0 or 1 is either fluid or row. so you do not recommend column. the only time this style error occurs is in a non recommended setting, ie column.

so again, given that we are now in a non-recommended setting (which i can only mean non-supported) why is that in-line style width there? it makes no sense to me. and i think it should be removed.

unless you can present a situation where that in-line style would be correct. which i would be more than willing/anxious to hear.

[lat9]

Thanks for sussing that out; same issue applies to the category_row.php module.