Color updates

[drbyte]

No description provided.

[drbyte]

There may be more areas to refine in regard to colors.
I'm okay with this remaining unmerged until we can review more.

[lat9]

Issue #21 opened to track these updates.

[dennisns7d]

While you're in this file, please review the header category tabs section. It appears to me that ZCA_HEADER_TABS_COLOR and ZCA_HEADER_TABS_COLOR_HOVER appear to have been swapped (perhaps since day one). Shouldn't ZCA_HEADER_TABS_COLOR apply to #navCatTabs a and ZCA_HEADER_TABS_COLOR_HOVER apply to #navCatTabs a:hover?

[drbyte]

While you're in this file, please review the header category tabs section. It appears to me that ZCA_HEADER_TABS_COLOR and ZCA_HEADER_TABS_COLOR_HOVER appear to have been swapped (perhaps since day one). Shouldn't ZCA_HEADER_TABS_COLOR apply to #navCatTabs a and ZCA_HEADER_TABS_COLOR_HOVER apply to #navCatTabs a:hover?

Are you saying this because visually it looks wrong? Or because text-descriptions mentally seem misaligned?

I'm having trouble seeing what you think it should look like visually.

[dennisns7d]

The text-descriptions seem misaligned.

I just looked at the admin side and found the same misalignment, so the two misalignments cancel out. Visually they are OK.

[dennisns7d]

The text-descriptions seem misaligned.

I just looked at the admin side and found the same misalignment, so the two misalignments cancel out. Visually they are OK.

My old eyes don't always work. Visually they're swapped between admin and store sides.

[dennisns7d]

admin/includes/init_includes/init_bc_config.php sets the following titles for the admin side:
ZCA_HEADER_TABS_COLOR: Header Category Tabs Color
ZCA_HEADER_TABS_COLOR_HOVER: Header Category Tabs Color on Hover
So the admin side is aligned.

The store side is reversed. Looking at the color values on the admin side, the Color on Hover is a lower value than Color. The Color on Hover is darker than Color. Looking at the store side, the color on hover is lighter than non-hover.

[drbyte]

You're right. It's reversed, and the default colors are therefore reversed too.

[drbyte]

I've added the following to this PR:

and PR'd an update to swap the default colors and improve the admin descriptions of those values: https://github.com/lat9/ZCA-Bootstrap-Template/pull/25/files

[drbyte]

If I've done it right, we might want to add something in the Release Notes that tells people who are upgrading to double-check (and possibly swap) the colors they've assigned for Header Category Tabs Color and Header Category Tabs Color on Hover, if they even have Category Tabs enabled.

[lat9]

Should we now include a stylesheet_configs.php (I'm sure there's a better name) to include these non-color-specific styling changes?

[drbyte]

Should we now include a stylesheet_configs.php (I'm sure there's a better name) to include these non-color-specific styling changes?

IMO no.

In theory end-users won't "need" to touch/edit this file, so if it contains one entry that's not color-related but pulls dynamic values from store configuration, it won't cause any confusion.
Plus, less-is-more performance-wise when it comes to loading assets such as stylesheets. The fewer the better.

If the current naming of stylesheet_colors.php is confusing in terms of semantics, I have no objection to it being renamed.