Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form entries, use placeholder instead of extra span to identify required fields. #265

Closed
lat9 opened this issue Jul 20, 2020 · 2 comments
Closed

Form entries, use placeholder instead of extra span to identify required fields. #265

lat9 opened this issue Jul 20, 2020 · 2 comments
Labels
change fix provided
Milestone
v2.3.5

Comments

@lat9
Copy link
Owner

lat9 commented Jul 20, 2020

... as identified in this Zen Cart support-thread post.
@lat9 lat9 added the change label Jul 20, 2020
@lat9
Copy link
Owner Author

lat9 commented Oct 27, 2020

While I can't point to the spot where this change was made, the current implementation of OPC uses those placeholders for the required fields:
image

@lat9 lat9 added not reproducible The issue cannot be reproduced and removed change labels Oct 27, 2020
@lat9 lat9 closed this as completed Oct 27, 2020
@simon1066
Copy link

Not sure if I'll be able to explain it properly but I guess what I'm getting at is, for Admin > Customer details > State - always as pulldown = false, the index.php?main_page=create_account page shows the asterisk inside the state field:
Screenshot 2020-10-27 132643

whereas checking out as a guest on the index.php?main_page=checkout_one page shows the asterisk outside the state field:

Screenshot 2020-10-27 132914

@lat9 lat9 reopened this Oct 27, 2020
@lat9 lat9 added change and removed not reproducible The issue cannot be reproduced labels Oct 27, 2020
lat9 added a commit that referenced this issue Oct 31, 2020
@lat9
#265: Use placeholder instead of span for non-dropdown State field.
eeeed5f
@lat9 lat9 added this to the v2.3.5 milestone Oct 31, 2020
@lat9 lat9 closed this as completed Nov 13, 2020
@lat9 lat9 mentioned this issue Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change fix provided
Projects
None yet
Milestone
v2.3.5
Development

No branches or pull requests
2 participants
@lat9 @simon1066