Update spec file #227
Open
Update spec file #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 72.79% 72.79%
=======================================
Files 41 41
Lines 4440 4440
Branches 449 449
=======================================
Hits 3232 3232
Misses 1052 1052
Partials 156 156Continue to review full report at Codecov.
|
|
Sorry I find this spec file, messy, ugly and confusing, but ok. |
simo5
approved these changes
Aug 11, 2017
tiran
force-pushed
the
specfile
branch
2 times, most recently
from
25a5dc4
to
b6a80cc
Compare
simo5
requested changes
Aug 11, 2017
custodia.spec
Outdated
| %endif # with_etcd | ||
|
|
||
| %if 0%{?with_ipa_python3} | ||
| %files -n python2-custodia-ipa |
There was a problem hiding this comment.
Should this be python3-custodia-ipa ?
| @@ -151,7 +138,20 @@ Sub-package with python3 custodia extra modules (etcdstore) | |||
|
|
|||
| %{overview} | |||
|
|
|||
| %endif # with_etcd | |||
| %if 0%{?with_ipa_python3} | |||
| %package -n python%{python3_pkgversion}-custodia-ipa | |||
There was a problem hiding this comment.
do we reallyneed to use %{python3_pkgversion} ?
custodia.spec
Outdated
| %global with_etcd 0 | ||
| %else | ||
| %global with_etcd 1 | ||
| %if 0%{?fedora} |
There was a problem hiding this comment.
Maybe %if 0%{?fedora} >= 26 here so if someone tries to build on f25 he'll get only py2 bits ?
- add python2-custodia-ipa with custodia.ipa plugins - ship /etc/custodia/ipa.conf - check RPMs with rpmlint - remove check for python-etcd on PPC, 0.4.5-5 no longer depends on etcd - use %tmpfiles_create macro to create /var/run/custodia in %post hook - simplify conflict with freeipa-server w/o Python 3 fix - drop workaround for Fedora 25 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes cheimes@redhat.com