Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lasso < 2.3 compatibility code. #136

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

thijskh
Copy link

@thijskh thijskh commented Jan 14, 2024

Since our minimum version is 2.4, this is essentially dead code. It was missed in the earlier cleanups (#129) because other compatibility code used ifdefs instead of this construct.

Since our minimum ersion is 2.4, this is essentially dead code.
It was missed in the earlier cleanups because other compatibility
code used ifdefs instead of this construct.
@thijskh thijskh requested a review from simo5 January 14, 2024 15:13
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thijskh thijskh merged commit a5c9c55 into main Jan 16, 2024
2 checks passed
@thijskh thijskh deleted the cleanup/compat-lasso-23 branch January 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants