-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up functions into multiple modules #5
Comments
This might get tricky around the compact conversion functions. I definitely want:
|
There are multiple ways to accomplish your goal. The simplest way is to rename the C extension _jose and then introduce a jose package and modules:
Each module imports the function it is interested in:
or wraps the functions:
|
Regarding module layout, I'm thinking:
The main change here is that I think this layout should be easy to make. Something like:
Thoughts? |
I advice against multiple shared libraries. It's a common practice to have an internal C module and do the rest in Python -- one internal shared library and a couple of Python modules as facade. It's easier, faster and simpler for development, too.In Python 2 a C extension does not have the ability to support sub-namespaces in packages. You can't easily share data between C extensions, e.g. exception types. Cython makes it a bit easier but it is still hacky. Layout
|
Closes: latchset#5 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Closes: latchset#5 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Closes: #5 Signed-off-by: Christian Heimes <cheimes@redhat.com>
Instead of this:
We want this:
The text was updated successfully, but these errors were encountered: