Push failure marking behavior out of worker and into the backend

latentflip · Jun 3, 2011 · e842215 · e842215
1 parent 91cc5de
commit e842215
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/delayed/backend/base.rb b/lib/delayed/backend/base.rb
@@ -121,6 +121,10 @@ def max_attempts
         payload_object.max_attempts if payload_object.respond_to?(:max_attempts)
       end
 
+      def fail!
+        update_attributes(:failed_at => self.class.db_time_now)
+      end
+
     protected
 
       def set_default_run_at

diff --git a/lib/delayed/worker.rb b/lib/delayed/worker.rb
@@ -152,7 +152,7 @@ def failed(job)
       if job.respond_to?(:on_permanent_failure)
         warn "[DEPRECATION] The #on_permanent_failure hook has been renamed to #failure."
       end
-      self.class.destroy_failed_jobs ? job.destroy : job.update_attributes(:failed_at => Delayed::Job.db_time_now)
+      self.class.destroy_failed_jobs ? job.destroy : job.fail!
     end
 
     def say(text, level = Logger::INFO)