Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings coverage of unit tests up to 100 per cent #243

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

hfwittmann
Copy link
Contributor

Hi Stephen,
here is my pull request, which brings the coverage of the unit tests up to 100%.
Best, Felix

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #243 into master will increase coverage by 1.71%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #243      +/-   ##
========================================
+ Coverage   94.28%    96%   +1.71%     
========================================
  Files          16     16              
  Lines         175    175              
  Branches        6      6              
========================================
+ Hits          165    168       +3     
+ Misses          2      0       -2     
+ Partials        8      7       -1
Impacted Files Coverage Δ
src/services/clickers.ts 98.11% <100%> (+1.88%) ⬆️
src/services/storage.ts 100% <0%> (+7.69%) ⬆️
src/pages/page2/page2.ts 100% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b400e7...3e2551f. Read the comment docs.

@lathonez lathonez merged commit bfce12f into lathonez:master Apr 25, 2017
@lathonez
Copy link
Owner

Thanks Felix!

@lathonez lathonez mentioned this pull request Apr 25, 2017
lathonez added a commit that referenced this pull request Apr 25, 2017
@hfwittmann hfwittmann deleted the 100coverage branch April 28, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants