Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up #244

Merged
merged 2 commits into from
Apr 30, 2017
Merged

clean up #244

merged 2 commits into from
Apr 30, 2017

Conversation

hfwittmann
Copy link
Contributor

remove unneccesary import

@hfwittmann
Copy link
Contributor Author

I am not sure what's gone wrong. I only tried to delete one line in storage.spec.ts, namely

import { StorageMock } from './mocks';

Locally all the tests run fine. Should I try again?

@lathonez
Copy link
Owner

Appveyor failed to load the webdriver, despite it being in the post install npm steps and being called explicitly before the tests run.

No idea why. Am rebuilding now (just to see what happens).

Will merge this regardless shortly. Thanks for the contribution

@codecov
Copy link

codecov bot commented Apr 30, 2017

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage      96%    96%           
=====================================
  Files          16     16           
  Lines         175    175           
  Branches        6      6           
=====================================
  Hits          168    168           
  Partials        7      7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6268157...daa3172. Read the comment docs.

@lathonez
Copy link
Owner

.. just rebuilding sorted it 👏 appveyor.

@lathonez lathonez merged commit 465da54 into lathonez:master Apr 30, 2017
@hfwittmann
Copy link
Contributor Author

Excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants