Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI Configuration #263

Merged
merged 3 commits into from
Jul 30, 2017
Merged

Circle CI Configuration #263

merged 3 commits into from
Jul 30, 2017

Conversation

stonelasley
Copy link
Contributor

This should be a good start to building on CircleCi. I left off the deployment step because it would be a shot in the dark.

A couple notes:

  1. ionic state clear seems to have been removed?
  2. I am running install ionic@latest which I dislike, however, there is no way to squelch the CLI update prompt which has been breaking my builds. I'm a not super enthusiastic about this. Has anyone come up with a better approach?
  3. Timezone probably needs to be updated or removed all-together.

@stonelasley
Copy link
Contributor Author

link to my last build https://circleci.com/gh/stonelasley/clicker/15

@codecov
Copy link

codecov bot commented Jul 29, 2017

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          16       16           
  Lines         186      186           
  Branches        6        6           
=======================================
  Hits          178      178           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2185f2d...84b3fd7. Read the comment docs.

@lathonez
Copy link
Owner

Hey,

This is excellent - thanks a lot.

Odd - we're using circle for another Ionic based project using ionic@someversion and it's not been a problem.

Will investigate why, merge your config with ours (your Chrome set up is a lot better than mine) and get this up on Circle.

Stephen

@lathonez lathonez merged commit 5fcfc38 into lathonez:master Jul 30, 2017
@lathonez
Copy link
Owner

I also wanted to move to CI 2 as part of this (as it's on my list for the other proj)

@lathonez
Copy link
Owner

Everything is up and running on circle 2.0. Thanks again for this.

@stonelasley
Copy link
Contributor Author

@lathonez, for as much as I've referenced this project it's the least I can do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants