Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test file name #8

Merged
merged 1 commit into from
Feb 23, 2016
Merged

fix test file name #8

merged 1 commit into from
Feb 23, 2016

Conversation

juliocbcotta
Copy link
Contributor

No description provided.

lathonez added a commit that referenced this pull request Feb 23, 2016
@lathonez lathonez merged commit 7555a93 into lathonez:master Feb 23, 2016
@lathonez
Copy link
Owner

Thanks a lot for this, very much appreciated. The more I think about all this the more I think we should start an Ionic 2 Seed repo as I mentioned on the Ionic issue.

You seem pretty interested in getting this stuff right, if you're interested in collaborating on something give me a shout.

@juliocbcotta
Copy link
Contributor Author

A seed project would bring some problems...

  • On going projects would have problems to benefit from it;
  • Ionic has at least 3 starters (blank, tabs, menu);
  • Not official;

I think, a better approach would be fork and create PRs to https://github.com/driftyco/ionic2-app-base/tree/typescript so existing projects would have a easy way to check a diff, all starters would use it and would be something official.

@lathonez
Copy link
Owner

Agreed.

On 24 February 2016 at 10:00, Júlio Cesar Bueno Cotta <
notifications@github.com> wrote:

A seed project would bring some problems...

  • On going projects would have problems to benefit from it;
  • Ionic has até least 3 starters (blank, tabs, menu);
  • Not official;

I think, a better approach would be fork and create PRs to
https://github.com/driftyco/ionic2-app-base/tree/typescript so existing
projects would have a easy way to check a diff, all starters would use it
and would be something official.


Reply to this email directly or view it on GitHub
#8 (comment).

@juliocbcotta
Copy link
Contributor Author

So... What should be our next steps?

  • fork the repo;
  • make clicker work with ionic2.beta.1 and angular2.beta.6 ( used in the app-base repo);
  • make the fork work with current clicker config for tests;
  • make the fork use webpack configs to make the build process unified;
  • make the tasks more flexible to allow run tests without recompile the code, run one test file;
  • create PR;
    Would it make sense to you?

@lathonez
Copy link
Owner

Yup sounds sensible.

I think an open question is whether or not the spec files should be kept with the source code.

https://github.com/mgechev/angular2-style-guide

I'm starting to think its nicer to keep everything together..?

Do you wanna fork & maybe give a heads up on the Ionic issue so others could get involved if they want? Then we can continue the discussion on the fork.

In the meantime I'll try to get my shit up to latest, but I may not be available until this evening (I'm UTC+13).

@juliocbcotta
Copy link
Contributor Author

I am also thinking about keep everything together... it seems the recommended way by angular team...
but I think it could be a "path" variable pointing to where the files are. if it points to "app/" or to "test/" should not be a big deal...
I am do what you said. I am UTC-3, keep update each other when possible.

@juliocbcotta
Copy link
Contributor Author

@lathonez
Copy link
Owner

cloned. Any chance you can enable issues / and give me push perms?

If you aren't comfortable with the latter I'm happy to do PRs.

On 24 February 2016 at 10:36, Júlio Cesar Bueno Cotta <
notifications@github.com> wrote:

fork url https://github.com/BugsBunnyBR/ionic2-app-base


Reply to this email directly or view it on GitHub
#8 (comment).

@juliocbcotta
Copy link
Contributor Author

just a sec.

@juliocbcotta
Copy link
Contributor Author

done.
Creating issue on ionic repo ionic-team/ionic-framework#5579
please, add/review anything you think is suitable.

@lathonez
Copy link
Owner

nice - I opened a few issues on your fork just to get your thoughts /
further our discussion from here.

On 24 February 2016 at 10:56, Júlio Cesar Bueno Cotta <
notifications@github.com> wrote:

done.
Creating issue on ionic repo ionic-team/ionic-framework#5579
ionic-team/ionic-framework#5579
please, add/review anything you think is suitable.


Reply to this email directly or view it on GitHub
#8 (comment).

@lathonez
Copy link
Owner

Just a heads' up that this repo is now up to date. Note #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants