angular2_rc1 conversion #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beetz12 - thanks a lot for this, it was on my list. I'll try to get on it this evening. |
|
@lathonez You are quite welcome. Your project has helped me tremendously in my ionic2/angular2 learning, it's the least I can do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the project to use angular2 rc1 per the change log below.
https://github.com/driftyco/ionic/blob/2.0/CHANGELOG.md
I've also done my best to fix the unit test. Unfortunately due to my limited testing knowledge, some jasmine and e2e tests remain broken.
Seeking a testing expert to fix the tests and merge this PR. Thanks!