-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/stackframe #1369
Merged
Merged
Hotfix/stackframe #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e chirality/flavor thread swizzle trick
…ered quark smearing operator when nvshmem is used
…through the addition of an offset parameter
Doesn't seem to break anything on 8xP100 in the tmLQCD HMC. |
weinbe2
reviewed
Apr 5, 2023
weinbe2
reviewed
Apr 5, 2023
weinbe2
reviewed
Apr 7, 2023
weinbe2
reviewed
Apr 7, 2023
weinbe2
reviewed
Apr 7, 2023
weinbe2
reviewed
Apr 7, 2023
weinbe2
reviewed
Apr 7, 2023
weinbe2
reviewed
Apr 7, 2023
Closed
weinbe2
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @maddyscientist ! Pending Jenkins completing this is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily serves to remove the induced stack frame in a number of kernels
__force_inline__
)SharedMemoryCache
to act as virtual registers (Symanzik improved Wilson-flow and STOUT kernels)Some other minor changes:
Matrix
functions