fix(protocol-parser): only append packed counter if there is dynamic data

[alvrs]

• The packed counter is only appended to the encoded data if there is dynamic data: https://github.com/latticexyz/mud/blob/main/packages/store/src/StoreCore.sol#L434-L442

[changeset-bot]

⚠️ No Changeset found

Latest commit: a425d2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[alvrs]

Current dependencies on/for this PR:

• main
  • PR feat(schema-type): add isDynamicAbiType #1096
    • PR fix(protocol-parser): only append packed counter if there is dynamic data #1097 👈
      • PR test(e2e): add more test cases #1074
        • PR feat(protocol-parser): add encodeKeyTuple #1099
          • PR feat(protocol-parser): add abiTypesToSchema #1100
            • PR test(e2e): actually sync from MODE in e2e test #1110
            • PR test(e2e): add test cases for dynamic data #1098

This comment was auto-generated by Graphite.

[holic]

do we want a test for this?

[alvrs]

do we want a test for this?

good call, that would be good, also as a baseline for folks who want to port this

[holic]

sorry, one more thing

it might make sense to do this check and return early so we avoid all the other work above and inner conditionals and such

shortly after const staticData = ..., do something like

if (!dynamicValues.length) {
  return `0x${staticData}`;
}

[alvrs]

agree, this also mirrors the on-chain logic better

The base branch was changed.