feat: add begin_with to start transaction with custom SQL #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebpom
changed the title
|
Decent start. Couple of nits:
|
|
Hi @abonander, ok, this is not a problem, I'll do it. |
|
glebpom
changed the title
abonander
requested changes
Jul 26, 2024
| #[doc(hidden)] | ||
| pub fn begin_with<S>( | ||
| conn: impl Into<MaybePoolConnection<'c, DB>>, | ||
| sql: S, |
There was a problem hiding this comment.
This can just be Cow<'static, str> here since it's not a public API. That will save on codgen.
| S: Into<Cow<'static, str>> + Send + 'a, | ||
| { | ||
| Box::pin(async move { | ||
| let rollback = Rollback::new(conn); |
There was a problem hiding this comment.
This should check and return an error if conn.transaction_depth > 0 because it doesn't make sense to allow this to create and release manual savepoints when a transaction is already in progress; that's just going to break things.
| S: Into<Cow<'static, str>> + Send + 'a, | ||
| { | ||
| Box::pin(async move { | ||
| let depth = conn.transaction_depth; |
There was a problem hiding this comment.
Same here re. checking transaction_depth.
|
@glebpom were you going to finish this? |
|
Closing due to inactivity. Feel free to open a new PR if you come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.