Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The track method is inconsistent with the TypeScript typings.d.ts file #23

Closed
tokestermw opened this issue May 13, 2020 · 3 comments
Closed

Comments

@tokestermw
Copy link

tokestermw commented May 13, 2020

Is this a support request?
No

Describe the bug

There are only two arguments in the .track method in the TypeScript file:

track(key: string, data?: any): void;

But three in the actual code:

function track(key, data, metricValue) {

To reproduce
When using the JS SDK, I can't compile the code using TypeScript because of Expected 1-2 arguments, but got 3. error.

Expected behavior
Should have three arguments

Logs
N/A

SDK version
"launchdarkly-react-client-sdk": "^2.18.0"

Language version, developer tools
Python, Node, React

OS/platform
Mac OS 10.15

Additional context
N/A

@eli-darkly
Copy link
Contributor

Sorry about this - it was just brought to our attention earlier today and we'll have a patch out ASAP.

LaunchDarklyCI pushed a commit that referenced this issue May 13, 2020
less strict matching of json content-type header
@eli-darkly
Copy link
Contributor

Note that the 3.2.8 release isn't something you should update separately - we will have a launchdarkly-js-client-sdk release out shortly that includes the fix.

@eli-darkly
Copy link
Contributor

OK, version 2.17.5 of the JS SDK has been released with the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants