Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused babel polyfill dependency #7

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

bdwain
Copy link
Contributor

@bdwain bdwain commented Jan 27, 2020

babel polyfill is not used, but package.json has a dependency on it. This removes it so that the package doesn't pull it in unnecessarily.

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Describe the solution you've provided
remove an unused dependency on babel polyfill

Provide a clear and concise description of what you expect to happen.
nothing

@bdwain bdwain changed the title remove babel polyfill dependency remove unused babel polyfill dependency Jan 27, 2020
@eli-darkly
Copy link
Contributor

Yes, it looks like this is obsolete (just to be absolutely sure Babel/Rollup wasn't pulling it in automatically somehow, I confirmed that this change has no effect on the build products). Thanks.

@eli-darkly eli-darkly merged commit 742ad58 into launchdarkly:master Jan 30, 2020
@bdwain
Copy link
Contributor Author

bdwain commented Jan 30, 2020 via email

LaunchDarklyCI pushed a commit that referenced this pull request Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants