add UI cmd #355
Merged
add UI cmd #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-zorn
reviewed
Jun 28, 2024
| @@ -57,6 +57,7 @@ func (c LDClient) RunServer(ctx context.Context, accessToken, baseURI, devStream | |||
| handler = handlers.CombinedLoggingHandler(os.Stdout, handler) | |||
| handler = handlers.RecoveryHandler(handlers.PrintRecoveryStack(true))(handler) | |||
| fmt.Println("Server running on 0.0.0.0:8765") | |||
| fmt.Println("Access the UI for toggling overrides at http://localhost:8765/ui or by running `ldcli dev-server ui`") | |||
There was a problem hiding this comment.
Suggested change
| fmt.Println("Access the UI for toggling overrides at http://localhost:8765/ui or by running `ldcli dev-server ui`") | |
| fmt.Println("✨✨✨ Access the UI for toggling overrides at http://localhost:8765/ui or by running `ldcli dev-server ui` ✨✨✨") |
There was a problem hiding this comment.
@mike-zorn oh I've tried to get emoji in the CLI before trust me - but apparently there's a risk that some terminals may not support it 😭
There was a problem hiding this comment.
😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭😭
mike-zorn
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go run . dev-server uishould pop open a new browser window for the UIalso adds a log line when the server starts to include those instructions as well ✨