fix: improve types of withLDProvider

[dsifford]

Requirements

• I have added test coverage for new or changed functionality
• I have followed the repository's pull request submission guidelines
• I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

Currently, the way that the withLDProvider function is implemented, end-users are unable to supply prop types for the wrapped component. This results in the type of the wrapped component to always be React.ComponentType<{}> which causes errors when the component is actually expected to have props.

This change makes the withLDProvider a generic function that end-users can supply props to.

Describe alternatives you've considered

There are no alternatives that I'm aware of.

Additional context

Ran into this issue in our codebase this afternoon. Pushing out a fix for this would be greatly appreciated.

[bwoskow-ld]

Thanks for the contribution!

The change itself looks fine, however, this branch doesn't adhere to our linter rules. Run npm run lint locally to see the errors. You can re-request my review once this is resolved.

[dsifford]

Whoops, sorry about that...

I think you might have two competing formatters or something. I noticed when I was working on this that prettier didn't seem to agree with tslint.

Should be good to go now.

[bwoskow-ld]

We have both prettier and tslint set up as they check for different things. Note that package.json has scripts defined for lint / lint:all as well as prettier.

There's still a lint issue when running tslint.

$ npm run lint

> launchdarkly-react-client-sdk@2.23.1 lint
> tslint -p tsconfig.json 'src/**/*.ts*'


ERROR: /Users/benwoskow/code/launchdarkly/react-client-sdk/src/withLDProvider.tsx:44:5 - Unsafe use of expression of type 'any'.
ERROR: /Users/benwoskow/code/launchdarkly/react-client-sdk/src/withLDProvider.tsx:50:31 - Insert `⏎`

Side note: our CircleCI build is supposed to be run on forked pull requests so that external contributors can see passing/failing checks via GitHub Actions. I don't know why that's not working automatically at the moment even though our CircleCI configuration says that it should be enabled. Apologies on the poor CI reporting automation here.

[dsifford]

@bwoskow-ld I am not seeing the same errors when I run lint:all

I went ahead and just added a new line at the end of the file (which I think is what the second error is that you're showing) but i did not address the error stemming from an unsafe expression because I did not touch that code.

[dsifford]

@bwoskow-ld Actually, I did not add a trailing new line at the end of the file because that triggers lint errors if I do.

How do you suggest we proceed here? We have breaking issues in our production code because of this that we have to now use @ts-ignore on for the time being.

[bwoskow-ld]

Thanks for pointing out the fact that the remaining lint issues weren't relating to your changes. That got me thinking that maybe the issue was on my end, which it was -- my linter wasn't using my intended configuration. To verify this I temporarily pushed your changes such that we could build them on our CircleCI account and they passed.

With that in mind, I'll take it from here and get you a release 😄

[bwoskow-ld]

This is now available in 2.23.2.