Expose ld provider #40

bezreyhan · 2020-06-09T21:26:53Z

Related issues
#39
#31

I've described the issue in detail in this PR: #39

Describe the solution you've provided
My PR is a fork of #31, but it also allows the ldClient to only be initialized once the user object has been defined. I've added a prop to LDProvider called waitForUserToInitializeClient. If this flag is set to true, then the LDClient won't be initialized until a the user prop has been defined.

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered
Here is another PR I've proposed: #39

bwoskow-ld · 2020-06-12T00:24:17Z

Hi @bezreyhan ,

I merged #31 just now -- please pull in the latest from launchdarkly:contrib to get those changes. The changes aren't yet on master as the changes aren't yet publicly available in any release.

We'll review this PR next week and if all goes well can include this in the next React SDK release along with #31.

Cheers,
Ben

bezreyhan · 2020-06-12T18:18:56Z

Hi @bwoskow-ld - I just updated my PR. Thanks for helping to push this along!

bezreyhan · 2020-06-22T23:55:59Z

Hi @bwoskow-ld, I just wanted to check on the status of this. Is there anything I can do to help?

bwoskow-ld · 2020-06-22T23:57:37Z

Sorry for the delay -- I've asked one of my teammates to look at it this week. Stay tuned.

yusinto

@bezreyhan apologies for the delay. I have left a few minor comments here, thank you very much for your PR.

yusinto · 2020-06-23T18:17:10Z

src/types.ts

+  /**
+   * If set to true, the ldClient will not be initialzed until the user prop has been defined.
+   */
+  waitForUserToInitializeClient?: boolean;
+


What do you think of calling this new prop deferInitialization instead? Reason being, there could be other reasons for doing this in the future in addition to waiting for the user object.

Yes, I'm happy to change it. Though, would you want a different flag to distinguish what we are deferring initialization for? For example, let's say we could defer initialization until props.foo is ready or props.user is ready. In the case that somebody wants to defer until props.foo is ready even though props.user is ready, we might need a separate flag to differentiate between the two ( e.g deferUntilFooIsReady vs deferUntilUserIsReady).

Though, I'm happy to name this w/e you think is best. deferInitialization sounds good to me.

At this time, I think we can safely assume deferring initialization only refers to the user and use the documentation to support this.

yusinto · 2020-06-23T18:18:32Z

src/provider.tsx

+  componentDidMount() {
+    const { user, waitForUserToInitializeClient } = this.props;
+    if (waitForUserToInitializeClient && !user) {
+      return;
+    }
+    this.initLDClient();
+  }
+
+  componentDidUpdate(prevProps: ProviderConfig) {
+    const { user, waitForUserToInitializeClient } = this.props;
+    const userJustLoaded = !prevProps.user && user;
+    if (waitForUserToInitializeClient && userJustLoaded) {
+      this.initLDClient();
+    }


Are you able to write tests for these please? Really appreciate your help, thanks.

yusinto · 2020-06-23T18:19:41Z

src/types.ts

@@ -48,6 +47,11 @@ export interface ProviderConfig {
   */
  user?: LDUser;

+  /**
+   * If set to true, the ldClient will not be initialzed until the user prop has been defined.


Typo in the comments here: initialzed => initialized

bezreyhan · 2020-06-26T17:04:39Z

@yusinto Thanks for taking a look at my changes. Please let me know if anything else is needed.

src/provider.tsx

yusinto · 2020-06-30T00:15:33Z

src/provider.tsx

+    const { user, deferInitialization } = this.props;
+    const userJustLoaded = !prevProps.user && user;
+    if (deferInitialization && userJustLoaded) {
+      return this.initLDClient();


Same here, regarding awaiting initLDClient.

same as above

For consistency with the behavior in componentDidmount, this should be awaited as well please.

src/provider.test.tsx

bezreyhan · 2020-07-13T16:32:48Z

@yusinto @bwoskow-ld thanks for looking at the PR. It's been a couple of weeks so I wanted to checkin and see if there is anything else that needs to be done. We would really benefit from this PR since our MAUs are about 1000% over our allowed amount and it's preventing us from using LD to it's full capacity.

I'm happy to make any other changes if needed. Please let me know. Thanks.

src/provider.tsx

yusinto · 2020-07-14T18:50:02Z

src/provider.tsx

+    const { user, deferInitialization } = this.props;
+    const userJustLoaded = !prevProps.user && user;
+    if (deferInitialization && userJustLoaded) {
+      return this.initLDClient();


For consistency with the behavior in componentDidmount, this should be awaited as well please.

yusinto

@bezreyhan thank you so much for your time and contribution!

…udit-for-sdk-related-repos-pt-2 Updates docs URLs

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) * Upgrade js-client-sdk version to 2.24.0 (#83) Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) * Upgrade js-client-sdk version to 2.24.0 (#83) * Upgrade common to 2.24.2 (#84) Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) * Upgrade js-client-sdk version to 2.24.0 (#83) * Upgrade common to 2.24.2 (#84) * Populate the context with the initial flag state and proxy. (#85) Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) * Upgrade js-client-sdk version to 2.24.0 (#83) * Upgrade common to 2.24.2 (#84) * Populate the context with the initial flag state and proxy. (#85) * [sc-178045] u2c changes for v3.0 release (#90) * Update js sdk version to prerelease * Renamed LDContext to ReactSdkContext * Added context to provider config. Replaced LDUser with context in init client function. Deprecated user prop in provider config. * Added getContextOrUser helper function. Replaced user props with getContextOrUser function. * Update js sdk to v3 alpha 2 to fix messages error * Replaced LDUser with LDContext. Added kind prop to test cases. * Update circleci node image version * Renamed wording "user" to "context". Added more test cases for provider. * Added more unit tests to cover backwards compatibility and new context. Renamed user to context in test data and comments. * Force async example to use js sdk alpha version * Update package.json * Add manual resolution for acorn to make webpack 4 work with optional chaining. Add context to init code. * [sc-177377] Update js dep to alpha3 * Update alpha packages * Removed redundant null coalescence. Added more unit tests for getContextOrUser. * Update package.json * Remove un-used import * Minor comment fixes * Removed unnecessary context arg in example init * Update app.js * Set default context kind to user * Create CODEOWNERS Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-178466] Bugfix flags proxy errors when using native functions (#91) * [sc-178466] Fix native function proxy errors * Added unit tests. * Fix ts any error * Update getFlagsProxy.test.ts Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update package.json (#92) Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com>

* Initial commit * Delete extraneous files from lib. * Update initLDClient.test.ts * Update withLDProvider.tsx (#18) * update JS SDK dependency to 2.16.3 * use JS SDK 2.17.0 * improve tests to clarify which options we're passing in and which ones are added by the wrapper * set wrapperName to react-client-sdk * lint * Update withLDProvider.test.tsx * update JS SDK to 2.17.5 + a few dev dependency bumps (#21) * downgrade typescript to 3.8.3 (#22) * [Fixes for] Expose LDProvider as a standalone component (#31) * remove startsWith usage (#23) * Fix the broken build (#24) * Expose ld provider (#40) * Add tests for the LDProvider * Add LDProvider component * Add LDProvider to main export * Update provider tests * Remove unused EnhancedComponent * Abstract function to generate react options * add waitForUserToInitializeClient flag to Provider * rename to LDProvider.tsx * fix tests * remove async from componentDidMount * fixes from CR * add test * cleanup * update types for componentDidUpdate * await initLDClient Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> * update to JS SDK 2.18.0 (adds disableSyncEventPost) (#25) * 45 fix providers to respect subscribed flags (#46) * Fixed asyncWithLDProvider.tsx and provider.tsx so that they only provide flag changes for subscribed flags. * Removed unused imports. * Addressed PR feedback. Fixed linting errors. Co-authored-by: Clay Embry <cembry@atlassian.com> * targetflags simplified logic (#26) * remove client-side ids from examples (#27) * update JS SDK to 2.18.1 * Fixing camelCaseKeys export (#44) * new js-common-sdk version (#30) * adding alias functionality (#31) * pin typedoc to unblock our releases (#32) * Removed the guides link * add inlineUsersToEvents to TypeScript defs by updating js-client-sdk (#33) * debugging * Fix linting errors * [ch103643] Fix examples to use local sdk * Remove unwanted changes. * Update package.json * Update yarn.lock * Update lock files. * Update package-lock.json * Update package-lock.json * Update package.json * Update link-dev.sh Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Update link-dev.sh * Update yarn.lock * Add react 17 peer dep (#61) * Update common JS SDK library to use fixes for debug event generation issues. (#36) * HOC static hoisting (#71) * Added a test for hoisting react statics in withLDProvider HOC * Fixed linting errors * Fixed more linting errors * update example app deps (#38) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders (#39) * Updated asyncWithLDProvider to fetch latest flag values when the Provider renders * Fixed linting * Updates docs URLs * fix: improve types of withLDProvider (#97) * [sc-107070] Include src for sourcemaps to work * [sc-127032] Omit deferInitialization from asyncWithLDProvider config * Removed and ignored lock files. * Update types.ts * Update typescript version (#44) * Update Makefile * Update Makefile * Deleting test-types.ts (#45) * [sc-132394] Add typedoc for AsyncProviderConfig (#47) Co-authored-by: Molly <molly.jones@launchdarkly.com> * Pass in client (#105) * [sc134057] Fix react sdk lint errors (#48) * remove custom TypeDoc build, use Releaser's standard logic (#49) * update js-client-sdk to 2.20.1 for localstorage error-handling fix and others * export more public symbols from entry point * [sc134364] Upgrade typescript, tslint and jest. (#50) Co-authored-by: Eli Bishop <eli@launchdarkly.com> * update js-client-sdk to 2.20.2 for sc-142333 fix (#53) * First commit. TODO: migrate enzyme to rtl. * Removed enzyme. Fixed prettier parentheses rule. * Fixed broken snapshot tests. Removed unused imports. * Update package.json * Update the version of the js-client-sdk * Update patch version. * Rename master to main (#56) * Set sendEventsOnlyForVariation by default * Add jest-environment-jsdom as explicit dependency * Fix TS error * Add jest-environment-jsdom as explicit dependency * Fix TS error * Update tests * Move wrapper options into base options obj * Target ES6 * Add tests for camel case cases * Remove vestigial package * Make targetFlags doc more clear * Add error hook and handler * Revert changes to original docs * Add context and flags proxy util * Use flags proxy and update tests * Fixup * Fixup * Don't call variation when initializing * Add option and failing test * Passing test * Remove incorrect comment and fix typo * Update proxy's get trap * except after c * Remove unproxied flags from context * Restore ldClient dec and clean up camelization * Update src/types.ts Co-authored-by: Molly <molly.jones@launchdarkly.com> * Fixup * Handle symbols * Add type constraint to withLDProvider * Remove getter setter * Remove error handler and fix bad merge * Update snapshots * Update releaser config * Fixup * Update version of js-client-sdk used. (#82) * Upgrade js-client-sdk version to 2.24.0 (#83) * Upgrade common to 2.24.2 (#84) * Populate the context with the initial flag state and proxy. (#85) * [sc-178466] Bugfix flags proxy errors when using native functions (#91) * [sc-178466] Fix native function proxy errors * Added unit tests. * Fix ts any error * Update getFlagsProxy.test.ts Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update config.yml Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: Martin Heller <github@technopolis.de> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: bezreyhan <bezreyhan@gmail.com> Co-authored-by: Nicholas Mitchell <nicholas@netlify.com> Co-authored-by: Martin Heller <mheller@testo.de> Co-authored-by: clayembry <clayembry@yahoo.com> Co-authored-by: Clay Embry <cembry@atlassian.com> Co-authored-by: Jonathan Felchlin <jonathan@xgecko.com> Co-authored-by: Mac Lockard <maclockard@gmail.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Nathan Waddell <45477581+NathanWaddell121107@users.noreply.github.com> Co-authored-by: Clifford Tawiah <ctawiah@launchdarkly.com> Co-authored-by: Cliff Tawiah <82856282+ctawiah@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Derek Sifford <dereksifford@gmail.com> Co-authored-by: Jaz White <jwhite@launchdarkly.com> Co-authored-by: Molly <molly.jones@launchdarkly.com> Co-authored-by: Tim Lee <tim.lee@red-badger.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Co-authored-by: Christie Williams <xie.williams@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com>

Nicholas Mitchell and others added 9 commits June 9, 2020 14:21

Add tests for the LDProvider

42b355b

Add LDProvider component

c23580d

Add LDProvider to main export

ba6da18

Update provider tests

e55960a

Remove unused EnhancedComponent

06a2ed7

Abstract function to generate react options

373d74d

add waitForUserToInitializeClient flag to Provider

4b8d45c

rename to LDProvider.tsx

dc6ac08

fix tests

41cb257

bwoskow-ld mentioned this pull request Jun 12, 2020

allow ldClient to be initialized manually #39

Closed

bwoskow-ld requested a review from yusinto June 12, 2020 00:24

bezreyhan changed the base branch from master to contrib June 12, 2020 18:08

bezreyhan force-pushed the expose-ld-provider branch from 0ceaa2f to debab91 Compare June 12, 2020 18:12

merge contrib

d5141c7

bezreyhan force-pushed the expose-ld-provider branch from debab91 to d5141c7 Compare June 12, 2020 18:13

remove async from componentDidMount

779abea

yusinto requested changes Jun 23, 2020

View reviewed changes

bezreyhan added 3 commits June 23, 2020 13:12

fixes from CR

f76a69d

add test

a487d9d

cleanup

ff3eb78

bezreyhan requested a review from yusinto June 23, 2020 23:44

yusinto requested changes Jun 30, 2020

View reviewed changes

update types for componentDidUpdate

7898bdc

bezreyhan requested a review from yusinto June 30, 2020 01:59

yusinto requested changes Jul 14, 2020

View reviewed changes

bezreyhan requested a review from yusinto July 15, 2020 17:04

await initLDClient

e4577d9

yusinto approved these changes Jul 15, 2020

View reviewed changes

bwoskow-ld merged commit 6db0f08 into launchdarkly:contrib Jul 15, 2020

LaunchDarklyCI mentioned this pull request Jul 15, 2020

prepare 2.19.0 release #41

Merged

LaunchDarklyReleaseBot pushed a commit that referenced this pull request Oct 6, 2021

Merge pull request #40 from launchdarkly/emberstevens/sc-118589/url-a…

d8a2b47

…udit-for-sdk-related-repos-pt-2 Updates docs URLs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose ld provider #40

Expose ld provider #40

bezreyhan commented Jun 9, 2020

bwoskow-ld commented Jun 12, 2020

bezreyhan commented Jun 12, 2020

bezreyhan commented Jun 22, 2020

bwoskow-ld commented Jun 22, 2020

yusinto left a comment

yusinto Jun 23, 2020

bezreyhan Jun 23, 2020 •

edited

Loading

yusinto Jun 26, 2020

yusinto Jun 23, 2020

yusinto Jun 23, 2020

bezreyhan commented Jun 26, 2020

yusinto Jun 30, 2020

bezreyhan Jun 30, 2020

yusinto Jul 14, 2020

bezreyhan commented Jul 13, 2020

yusinto Jul 14, 2020

yusinto left a comment

Expose ld provider #40

Expose ld provider #40

Conversation

bezreyhan commented Jun 9, 2020

bwoskow-ld commented Jun 12, 2020

bezreyhan commented Jun 12, 2020

bezreyhan commented Jun 22, 2020

bwoskow-ld commented Jun 22, 2020

yusinto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bezreyhan Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bezreyhan commented Jun 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bezreyhan commented Jul 13, 2020

Choose a reason for hiding this comment

yusinto left a comment

Choose a reason for hiding this comment

bezreyhan Jun 23, 2020 •

edited

Loading