Skip to content

Commit

Permalink
Revert "Desktop: Resolve #3695: Show notebook and note title in the t…
Browse files Browse the repository at this point in the history
…itle bar (#4390)"

This reverts commit c79c9c4.

Reason: Still need to discuss how it should be implemented. Ref:

https://discourse.joplinapp.org/t/testing-v1-8-2-title-bar-path-format-minor/16937/10
  • Loading branch information
laurent22 committed May 4, 2021
1 parent eb82ae8 commit a0ead2c
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 94 deletions.
6 changes: 0 additions & 6 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -616,12 +616,6 @@ packages/app-desktop/gui/ToolbarButton/styles/index.js.map
packages/app-desktop/gui/dialogs.d.ts
packages/app-desktop/gui/dialogs.js
packages/app-desktop/gui/dialogs.js.map
packages/app-desktop/gui/getWindowTitle.d.ts
packages/app-desktop/gui/getWindowTitle.js
packages/app-desktop/gui/getWindowTitle.js.map
packages/app-desktop/gui/getWindowTitle.test.d.ts
packages/app-desktop/gui/getWindowTitle.test.js
packages/app-desktop/gui/getWindowTitle.test.js.map
packages/app-desktop/gui/hooks/useEffectDebugger.d.ts
packages/app-desktop/gui/hooks/useEffectDebugger.js
packages/app-desktop/gui/hooks/useEffectDebugger.js.map
Expand Down
6 changes: 0 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -603,12 +603,6 @@ packages/app-desktop/gui/ToolbarButton/styles/index.js.map
packages/app-desktop/gui/dialogs.d.ts
packages/app-desktop/gui/dialogs.js
packages/app-desktop/gui/dialogs.js.map
packages/app-desktop/gui/getWindowTitle.d.ts
packages/app-desktop/gui/getWindowTitle.js
packages/app-desktop/gui/getWindowTitle.js.map
packages/app-desktop/gui/getWindowTitle.test.d.ts
packages/app-desktop/gui/getWindowTitle.test.js
packages/app-desktop/gui/getWindowTitle.test.js.map
packages/app-desktop/gui/hooks/useEffectDebugger.d.ts
packages/app-desktop/gui/hooks/useEffectDebugger.js
packages/app-desktop/gui/hooks/useEffectDebugger.js.map
Expand Down
19 changes: 9 additions & 10 deletions packages/app-desktop/gui/Navigator.jsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
const React = require('react');
const Component = React.Component;
const Setting = require('@joplin/lib/models/Setting').default;
const { connect } = require('react-redux');
const bridge = require('electron').remote.require('./bridge').default;
const getWindowTitle = require('./getWindowTitle').default;


class NavigatorComponent extends Component {
constructor(props) {
super(props);
}
UNSAFE_componentWillReceiveProps(newProps) {
if (newProps.route) {
this.updateWindowTitle(getWindowTitle(newProps.notes, newProps.selectedNoteIds, newProps.selectedFolderId, newProps.folders, newProps.screens, newProps.route));
const screenInfo = this.props.screens[newProps.route.routeName];
const devMarker = Setting.value('env') === 'dev' ? ' (DEV)' : '';
const windowTitle = [`Joplin${devMarker}`];
if (screenInfo.title) {
windowTitle.push(screenInfo.title());
}
this.updateWindowTitle(windowTitle.join(' - '));
}
}

updateWindowTitle(title) {
try {
if (bridge().window()) bridge().window().setTitle(title);
Expand Down Expand Up @@ -46,10 +49,6 @@ class NavigatorComponent extends Component {
const Navigator = connect(state => {
return {
route: state.route,
selectedNoteIds: state.selectedNoteIds,
selectedFolderId: state.selectedFolderId,
folders: state.folders,
notes: state.notes,
};
})(NavigatorComponent);

Expand Down
47 changes: 0 additions & 47 deletions packages/app-desktop/gui/getWindowTitle.test.ts

This file was deleted.

25 changes: 0 additions & 25 deletions packages/app-desktop/gui/getWindowTitle.ts

This file was deleted.

0 comments on commit a0ead2c

Please sign in to comment.