Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a link in beta editor selects random text #10538

Closed
laurent22 opened this issue Jun 4, 2024 · 0 comments · Fixed by #10542
Closed

Adding a link in beta editor selects random text #10538

laurent22 opened this issue Jun 4, 2024 · 0 comments · Fixed by #10542
Assignees
@personalizedrefrigerator
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues

Comments

@laurent22
Copy link
Owner

Operating system

Windows

Joplin version

3.0.7

Desktop version info

No response

Current behaviour

Type this in the editor:

abcd

Click on the button to add a link

Click OK

=> Some random text is selected:

image

I think originally the cursor is meant to be inside the [] brackets so that the user can type in the link text

Expected behaviour

No response

Logs

No response
@laurent22 laurent22 added bug It's a bug desktop All desktop platforms editor high High priority issues labels Jun 4, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jun 4, 2024
@personalizedrefrigerator
Desktop: Fixes laurent22#10538: Fix wrong text selected when adding a…
967cd24 
… link in the beta editor

This pull request migrates `wrapSelections` away from CodeMirror 5 APIs
and makes it instead reuse code written for the same purpose on mobile.
Merged
laurent22 pushed a commit that referenced this issue Jun 11, 2024
@personalizedrefrigerator
Desktop: Fixes #10538: Fix wrong text selected when adding a link in …
b17f28c 
…the beta editor (#10542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@personalizedrefrigerator personalizedrefrigerator

Labels
bug It's a bug desktop All desktop platforms editor high High priority issues
Projects
None yet
Milestone
No milestone
2 participants
@laurent22 @personalizedrefrigerator