Desktop: Fixes #10538: Fix wrong text selected when adding a link in the beta editor #10542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link in the beta editor This pull request migrates `wrapSelections` away from CodeMirror 5 APIs and makes it instead reuse code written for the same purpose on mobile.
There was a problem hiding this comment.
Most of markdownReformatter isn't specific to markdown. As such, this commit renames it to editorStateUtils and uses one of its utility functions to implement wrapSelections (which also isn't markdown-specific).
A follow-up pull request should break editorStateUtils into separate files in the util folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #10538 by migrating
wrapSelectionsaway from legacy CodeMirror 5 APIs.Note
Although this pull request does some refactoring in the
editorpackage, additional refactoring should be done in a follow-up PRTesting plan
This pull request contains automated tests that partially test this change. As such, this pull request has also been tested manually by:
[]s for the new link.This has been tested successfully on Ubuntu 24.04.