-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joplin crashes when trying to Change application layout #5111
Comments
@mablin7, the error seems to indicate an issue with the recent layout change. Any idea what might be the issue?
|
Yes, it's most likely my bad. I'll look into it today. |
Hm I cannot reproduce this on either 2.0.11 or the dev brach. Could you attach here your settings.json file? I suspect this has to do with the plugins you had, even if you uninstalled them. As far as I know, their panels remain in the layout. Here's how to find the settings.json file:
I don't think it can contain any personal information, but you should take a look before sending. I'm only interested in the |
Here it is, my |
Hi. I renamed the Well, I expect this gives you any clue about what could happened and I'll move to continue playing and enjoying Joplin . Note: Do I have to close the bug? Please, let me know ....or feel free to do it. |
Hey sorry I haven't had time to really look into this, but I surely will. You shouldn't close this issue as the problem still exists, but I'm glad you found a workaround. |
Ok @mablin7, thank you. |
@mablin7, if the bug cannot be replicated, is there any way to add a null check on the line where the error happened? It seems null items sometimes make their way into the layout but it's not clear how. However if we can at least prevent it from crashing that would be a start. |
Right, that sounds reasonable, I'll do it |
I hit this issue also, I am on Mac Joplin 2.1.8 (prod, darwin). tl;dr: I was able to fix this by deleting the Repro steps(Note: I recently had an SQL issue and so it is possible that my app just got into a strange state while restoring, so please take this report with a grain of salt)
Crash log - Cannot read property 'maxSize' of null (plugins installed)
Crash log - Cannot read property 'maxSize' of null (jn safe mode)
Crash log - Could not get plugin info: Error: Plugin not found: joplin.plugin.ambrt.backlinksToNote
Settings ui.layout``` "ui.layout": { "key": "root", "children": [ { "key": "tempContainer-5WW9QHxTwhJDWLEtE3IEzZ", "children": [ { "key": "sideBar", "visible": true } ], "visible": true }, { "key": "tempContainer-Ta1fthRDypt7Enxic3vwca", "children": [ { "key": "noteList", "visible": true } ], "visible": true }, { "key": "editor", "visible": true } ], "visible": true }, ```
Crash log - n reducer: Cannot read property 'key' of null Action: {"type":"MAIN_LAYOUT_SET_ITEM_PROP","itemKey":"plugin-view-joplin.plugin.ambrt.backlinksToNote-backlinksPanel","propName":"visible","propValue":true}
|
After updating from 1.8.5 to 2.0.11, I wanted to reorder my layout.
When I try to change application layout, application crashes when it affects the main editor section. I can move any other component freely but that action can't affect main editor.
Steps:
View
menu, selectChange application layout
option.3.1. If I try to relocate the
Main editor
section, Joplin crashes.3.2. If I try to relocate any section ( Menu, Favorites ), Joplin works, but if the relocation affects
Main editor
, Joplin crashes.I though that it could be caused by a Plugin, but no. I checked after disabling and finally uninstalling them all. Then I have only reinstalled
Favorites
plugin.Environment
Joplin version: Joplin Desktop
Platform: Windows
OS specifics: 10 (21H1 - 19043.1055)
Steps to reproduce
Describe what you expected to happen
Reorder layout objects, as usual.
After updating from 1.8.5 to 2.0.11, I wanted to reorder my layout.
I have uninstalled some plugins also and it persits.
I haven't personalized it using the css files.
Logfile
When the error occurs, a page window appears doing impossible to continue working. That's the attached log. I also started Joplin by enabling debugging flags using the
flags.txt
file, but I found same messages in the console.I don't have experience in Joplin development, and Electron either, but I saw that it is continuously looking for a resources folder in install folder
D:\Program Files (Medea)\Joplin\resources\app.asar\ [FILES]
, butapp.asar
is a file and not a folder (I think everything is inside, like a library, don't know hehe).Environment
Joplin version: Joplin Desktop
Platform: Windows
OS specifics: 10 (21H1 - 19043.1055)
Steps to reproduce
Describe what you expected to happen
Reorder layout objects, as usual.
After updating from 1.8.5 to 2.0.11, I wanted to reorder my layout.
I have uninstalled some plugins also and it persits.
I haven't personalized it using the css files.
Logfile
Error
Joplin encountered a fatal error and could not continue. To report the error, please copy the entire content of this page and post it on Joplin forum or GitHub.
To continue you may close the app. Alternatively, if the error persists you may try to restart in safe mode, which will temporarily disable all plugins.
Message
Cannot read property 'maxSize' of null
Version info
Joplin for Desktop
Copyright © 2016-2021 Laurent Cozic
Joplin 2.0.11 (prod, win32)
Client ID: 14362837e7d44f8dad0ca81379d4d6bc
Sync Version: 2
Profile Version: 39
Keychain Supported: Yes
Revision: 981b1d8
Plugins
[
{
"id": "io.github.jackgruber.combine-notes",
"name": "Combine notes",
"enabled": true,
"version": "0.2.2"
},
{
"id": "joplin.plugin.ambrt.convertToNewNote",
"name": "Convert Text To New Note",
"enabled": true,
"version": "1.5.0"
},
{
"id": "joplin.plugin.ambrt.goToItem",
"name": "Create and go to #tags and @notebooks",
"enabled": true,
"version": "1.3.7"
},
{
"id": "joplin.plugin.ambrt.embedSearch",
"name": "Embed Search",
"enabled": true,
"version": "1.0.11"
},
{
"id": "joplin.plugin.note.tabs",
"name": "Note Tabs",
"enabled": false,
"version": "1.3.0"
},
{
"id": "joplin.plugin.benji.favorites",
"name": "Favorites",
"enabled": true,
"version": "1.2.1"
},
{
"id": "com.export-to-ssg.aman-d-1-n-only",
"name": "Export To SSG",
"enabled": true,
"version": "1.0.3"
},
{
"id": "joplin.plugin.ambrt.fold-cm",
"name": "Folding in Code Mirror Editor",
"enabled": true,
"version": "1.2.5"
},
{
"id": "joplin.plugin.anki-sync",
"name": "Joplin Anki Sync",
"enabled": true,
"version": "1.0.0"
},
{
"id": "com.whatever.inline-tags",
"name": "Inline tags",
"enabled": true,
"version": "1.1.3"
},
{
"id": "plugin.azamahJunior.note-statistics",
"name": "Note Statistics",
"enabled": true,
"version": "1.0.4"
},
{
"id": "io.github.jackgruber.note-overview",
"name": "Note overview",
"enabled": true,
"version": "1.4.3"
},
{
"id": "joplin.plugin.spoiler.cards",
"name": "Spoilers",
"enabled": true,
"version": "1.0.3"
},
{
"id": "plugin.calebjohn.rich-markdown",
"name": "Rich Markdown",
"enabled": true,
"version": "0.4.7"
}
]
Stack trace
TypeError: Cannot read property 'maxSize' of null
at renderLayoutItem (D:\Program Files (Medea)\Joplin\resources\app.asar\gui\ResizableLayout\ResizableLayout.js:86:139)
at renderLayoutItem (D:\Program Files (Medea)\Joplin\resources\app.asar\gui\ResizableLayout\ResizableLayout.js:102:41)
at ResizableLayout (D:\Program Files (Medea)\Joplin\resources\app.asar\gui\ResizableLayout\ResizableLayout.js:117:22)
at renderWithHooks (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:15108:18)
at updateFunctionComponent (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:16925:20)
at beginWork$1 (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:18498:16)
at HTMLUnknownElement.callCallback (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:347:14)
at Object.invokeGuardedCallbackDev (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:397:16)
at invokeGuardedCallback (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:454:31)
at beginWork$$1 (D:\Program Files (Medea)\Joplin\resources\app.asar\node_modules\react-dom\cjs\react-dom.development.js:23217:7)
Component stack
React will try to recreate this component tree from scratch using the error boundary you provided, ErrorBoundary.
The text was updated successfully, but these errors were encountered: