Desktop : Added bottom space to the AceEditor #3156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some conflicts now, so I think you need to move your changes to AceEditor.tsx |
|
Sure i'll just move the changes |
|
I'll close this for now, but feel free to let me know when you've fixed the conflict and we can re-open and merge. |
tessus
added a commit
to tessus/joplin
that referenced
this pull request
Jul 17, 2020
follow-up to laurent22#3156 fixes laurent22#3147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3147
BEFORE
AFTER (Look at the bottom of editor)