Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Fixes #6688: Fix resources sync when proxy is set #6817

Merged
merged 1 commit into from
Sep 5, 2022
Merged

All: Fixes #6688: Fix resources sync when proxy is set #6817

merged 1 commit into from
Sep 5, 2022

Conversation

wh201906
Copy link
Contributor

@wh201906 wh201906 commented Sep 5, 2022

This PR fixes #6688
The url argument in shim.fetchBlob() is a Url object. Passing it to isUrlHttps() will cause an error.

@laurent22 laurent22 merged commit eb7083d into laurent22:dev Sep 5, 2022
@laurent22
Copy link
Owner

Thanks for fixing this!

@wh201906
Copy link
Contributor Author

wh201906 commented Sep 5, 2022

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't fetch resource when set proxy
2 participants