Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Fixes #6440 Enable translation for 1 command #8852

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Desktop: Fixes #6440 Enable translation for 1 command #8852

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a29ea4
Fixed command labels not being translated
CptMeetKat Sep 12, 2023
cf870d2
Merge branch 'laurent22:dev' into issue-6440-command-translations
CptMeetKat Sep 12, 2023
dce062d
Restored unsupported command to previous state
CptMeetKat Sep 13, 2023
5719fd7
Merge branch 'issue-6440-command-translations' of github.com:CptMeetK…
CptMeetKat Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app-desktop/commands/restoreNoteRevision.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { CommandRuntime, CommandDeclaration, CommandContext } from '@joplin/lib/services/CommandService';
import RevisionService from '@joplin/lib/services/RevisionService';
import { _ } from '@joplin/lib/locale';

export const declaration: CommandDeclaration = {
name: 'restoreNoteRevision',
label: 'Restore a note from history',
label: () => _('Restore a note from history'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't translate this, it's not officially supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I reverted the change to that file and updated the PR

};

export const runtime = (): CommandRuntime => {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-desktop/gui/MainScreen/commands/revealResourceFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import bridge from '../../../services/bridge';

export const declaration: CommandDeclaration = {
name: 'revealResourceFile',
label: _('Reveal file in folder'),
label: () =>_('Reveal file in folder'),
};

export const runtime = (): CommandRuntime => {
Expand Down
Loading