Desktop: Fixes #6440 Enable translation for 1 command #8852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CptMeetKat
changed the title
laurent22
reviewed
Sep 12, 2023
|
|
||
| export const declaration: CommandDeclaration = { | ||
| name: 'restoreNoteRevision', | ||
| label: 'Restore a note from history', | ||
| label: () => _('Restore a note from history'), |
There was a problem hiding this comment.
We won't translate this, it's not officially supported
There was a problem hiding this comment.
No worries, I reverted the change to that file and updated the PR
…at/joplin into issue-6440-command-translations
CptMeetKat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the label on command revealResourceFile was not translating.
By adding an arrow function this allows the command's labels to correctly be deferred to runtime for localisation.
This change brings this command in line with other like commands that do produce accurate translations.
Previously
Test Examples
Test Steps
Fixes #6440