Add write permission to user before removal #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This question is very important. Please, merge in project |
laurent22
reviewed
Mar 30, 2021
rsync_tmbackup.sh
Outdated
| @@ -89,6 +89,7 @@ fn_expire_backup() { | |||
| fi | |||
|
|
|||
| fn_log_info "Expiring $1" | |||
| fn_run_cmd "chmod -R u+w $1" | |||
There was a problem hiding this comment.
Needs single quotes around "$1"
|
I have rebased the branch to master with quotes added. |
|
The pull request now includes 3 unrelated additional changes, so please could you remove them? If other fixes are needed they should be done in a separate pull request. |
dankh
force-pushed
the
chmod-before-delete-expired
branch
from
86d7077
to
45149a3
Compare
|
Rebase removed, only my changes present in pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If backup has expired and there are read only files the files won't be deleted and the backup will never expire.