Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit Revert of Revert #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudiu-cristea
Copy link

@claudiu-cristea claudiu-cristea commented Jan 1, 2017

Read next commit messages:

Revert "Revert "Issue #2241633 by sun: Simplify site-specific service overrides.""

Revert "Revert "Issue #2457653 by Gábor Hojtsy: System.site langcode is both used as a file language code and a site language code""

Revert "Revert "Issue #2489922 by anavarre, RavindraSingh: Fix minor typos""

Revert "Revert "Issue #2510104 by pwolanin, nod_, Fabianx, Wim Leers, droplet, Pere Orga: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future""

Revert "Revert "Issue #2761403 by Berdir: Move runtime theme registry into bootstrap cache""

Revert "Revert "Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface""

Because of the revert regexp in json.rb

reverts_regexp = Regexp.new '^Revert \"(?<credits>.+#[0-9]+.* by [^:]+:).*'
reverts_regexp_loose = Regexp.new '^Revert .*(?<issue>#[0-9]+).*'

...these commit messages are considered reverts and are not credited. But these are valid contributions because the original commit was reverted (the contributor is not credited) and, then, the revert is reverted -- as a consequence this is the commit where the contribution gets in and the contributor should be credited.

@wimleers
Copy link

wimleers commented Dec 6, 2017

Seems like this should still land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants