Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 + utf-8 problem #58

Closed
plentz opened this issue Oct 14, 2013 · 7 comments
Closed

IE8 + utf-8 problem #58

plentz opened this issue Oct 14, 2013 · 7 comments

Comments

@plentz
Copy link

plentz commented Oct 14, 2013

if you compress ivaynberg/select2 code, it will generate invalid code for IE8(even leaving :screw_ie8 = false - the default)

https://github.com/ivaynberg/select2/blob/master/select2.js#L101

ie

@plentz
Copy link
Author

plentz commented Oct 14, 2013

Found the problem: IE fails to handle some utf-8 chars(like that one) in object literals without the quotes. To solve the problem, I had to use :quote_keys => true.

@plentz
Copy link
Author

plentz commented Oct 14, 2013

cc @ivaynberg just in case somebody open an issue about using rails + asset pipeline + uglifier

@plentz
Copy link
Author

plentz commented Oct 14, 2013

As a permanent solution, I think we should set :quote_keys => true as default when :screw_ie8 = false. What do you think?

@plentz
Copy link
Author

plentz commented Oct 14, 2013

cc @argerim just in case somebody open an issue about using rails + asset pipeline + uglifier

@lautis
Copy link
Owner

lautis commented Oct 15, 2013

This seems to be related to #47, although it might be that IE8 has different rules for valid identifiers.

lautis added a commit that referenced this issue Oct 19, 2013
Update UglifyJS to latest commit in master. Older versions incorrectly
allow some Unicode characters to appear at the beginning of an identifier.

Fixes #47 and #58.
@lautis lautis closed this as completed Oct 19, 2013
@plentz
Copy link
Author

plentz commented Oct 19, 2013

awesome!

@plentz
Copy link
Author

plentz commented Jan 24, 2014

related #67

jasonadamyoung pushed a commit to extension/data that referenced this issue Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants