Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiproc bug #177

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Multiproc bug #177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f31acb
Check process lineage before join
mgkwill Feb 9, 2022
5e3d14c
Merge branch 'lava-nc:main' into multiproc_bug
mgkwill Feb 9, 2022
6fff6fd
Merge branch 'main' into multiproc_bug
mgkwill Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lava/magma/runtime/message_infrastructure/multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
AbstractRuntimeServiceBuilder

import multiprocessing as mp
import os
from multiprocessing.managers import SharedMemoryManager
import traceback

Expand Down Expand Up @@ -76,7 +77,8 @@ def build_actor(self, target_fn: ty.Callable, builder: ty.Union[
def stop(self):
"""Stops the shared memory manager"""
for actor in self._actors:
actor.join()
if actor._parent_pid == os.getpid():
actor.join()

self._smm.shutdown()

Expand Down